Skip to content

test(angular-rspack): refine unit tests of create-config.ts #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

test(angular-rspack): refine unit tests of create-config.ts #8

wants to merge 5 commits into from

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Mar 9, 2025 •
edited
Loading

This PR includes:

  • un-nesting of describe blocks
  • remove conditional expect logic
  • added test cases for options only

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit da32127.

Command Status Duration Result
nx-cloud record -- pnpm check-commit ❌ Failed 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-15 18:10:50 UTC

@BioPhoton BioPhoton requested a review from Coly010 March 9, 2025 12:56
@Coly010 Coly010 force-pushed the main branch 7 times, most recently from bb3b981 to 12a4f2a Compare March 12, 2025 14:00
Coly010
Coly010 requested changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withConfigurations doesn't exist anymore.
There have been changes to the createConfig to merge those two functions together.

@BioPhoton
Merge branch 'main' into test/angular-rspack/with-configuration
cbd4159 
# Conflicts:
#	packages/angular-rspack/src/lib/config/create-config.unit.test.ts
@BioPhoton BioPhoton closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coly010 Coly010 Coly010 requested changes

Assignees
No one assigned
Labels
📖 documentation 🧪 testing 🛠️ tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BioPhoton @Coly010